Skip to content

fixing schema parsing in json models with non-str pks #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

fixing schema parsing in json models with non-str pks #622

merged 2 commits into from
Jul 10, 2024

Conversation

slorello89
Copy link
Member

Fixes #619 (copy paste issue from hash model for non-str pks), also adding back a couple of tests that were squashed away from some previous re-bases

@sav-norem
Copy link
Contributor

Added test marking to resolve merge conflict

@sav-norem sav-norem self-requested a review July 8, 2024 13:35
@slorello89 slorello89 merged commit dda2897 into main Jul 10, 2024
@slorello89 slorello89 deleted the bugfix/non-string-pks-json branch July 10, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sav-norem sav-norem sav-norem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JsonModel.schema_for_type() missing 2 required positional arguments: 'typ' and 'field_info'
2 participants
@slorello89 @sav-norem